From what i have learnt over the last couple of days.
CloudKit\iCloud Photos\MMCS is filling up nicely.
I kept freeing up space on my hard drive only for it to vanish a couple of hours later and using spacesniffer it clearly shows that CloudKit\iCloud Photos\MMCS it hogging all the space. I even used the windows diskcleanup software which in all my years of computing i have never done before, I was amazed how much room i got back. Left it overnight and CloudKit\iCloud Photos\MMCS had filled up another 25Gb !!
I recently took some videos on my iphone of lightning and the files sizes are quite big so i decided to copy and rename a tmp file in the CloudKit\iCloud Photos\MMCS folder to .mp4 and as i was expecting it was a copy of one of the videos.
i used icloud for photos and it copies photos and videos from my iphone onto my computer. I have all these files in my Icloud photos folder. so thats working ok.
I have read somewhere that icloud still needs a copy saved on your computer as another backup for the icloud. Dont know if thats correct but does sound plausible however it would be nice to know if this is true. This would explain why the CloudKit\iCloud Photos\MMCS is so large. Im not sure if this is only for icloud drive (don't use this feature at all)
I did have problem before where icloud photos was not downloading my photos and i had to manually download them to start the ball rolling. From then on the service seems to have worked. However when i did manually download i had 2 copies of everything in 2 seperate folders and had to delete some as it was taking up space and also it only updated one folder.
So it may be a configuration issue and it doesn't know what to keep and what to delete amongst the TMP files within CloudKit\iCloud Photos\MMCS
Now looking at this case, this is just 1 phone that its backing up. So is only containing files from a single phone. Now if you had a couple of iphones and a ipod and maybe a ipad. the amount of files could be 3-4 times that of a single iphone so the CloudKit\iCloud Photos\MMCS folder could be huge and deleting it would be silly unless you were sure you definitely had a copy of every file you wanted to keep.
OK, my next move.
What i am going to do is take all my photos and videos off my iphone (needs a de-clutter anyway) and make sure there are none left on my iphone and all saved on my pc.
Then i'm going to perform another Disk Clean and use CCleaner and just check everything has gone and see what happens overnight. Hopefully there will be nothing to download from my phone and CloudKit\iCloud Photos\MMCS will not fill up. if it does then CloudKit\iCloud Photos\MMCS must be storing file from icloud itself. I don't see any other explanation.
Well thats my 2 pence and my observations, may be wrong but im going to give it a try. Hope this helps someone,